Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StringType repr #1129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update StringType repr #1129

wants to merge 1 commit into from

Conversation

sfc-gh-yixie
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie sfc-gh-yixie requested a review from a team as a code owner November 5, 2023 04:38
sfc-gh-sfan
sfc-gh-sfan reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a JIRA associated with this? If yes, please attach to the PR title. If not, please be more descriptive on why we want to make this change in the PR description.

@sfc-gh-yixie
Copy link
Collaborator Author

@sfc-gh-aalam I'm very confused why this test failed from this change. It looks irrelevant to StringType.
FAILED tests/integ/test_udf.py::test_udf_timestamp_type_hint

sfc-gh-stan
sfc-gh-stan reviewed Nov 7, 2023
View reviewed changes
src/snowflake/snowpark/types.py
@@ -84,7 +84,7 @@ def __init__(self, length: Optional[int] = None) -> None:
self.length = length

def __repr__(self) -> str:
if self.length:
if self.length and self.length != self._MAX_LENGTH:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we display the length when it's MAX_LENGTH?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is when the length is not max_length.

@sfc-gh-stan
Copy link
Collaborator

Do we not have a JIRA associated with this? If yes, please attach to the PR title. If not, please be more descriptive on why we want to make this change in the PR description.

I'm also curious as to why we need this change. Is this going to a BCR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan left review comments

@sfc-gh-stan sfc-gh-stan sfc-gh-stan left review comments

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg Awaiting requested review from sfc-gh-lspiegelberg sfc-gh-lspiegelberg was automatically assigned from snowflakedb/snowpark-python-api

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-yixie @sfc-gh-stan @sfc-gh-sfan @sfc-gh-aalam