-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Interval expression to Snowpark API #1191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
sfc-gh-nkrishna
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
and removed
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
labels
Jan 4, 2024
sfc-gh-nkrishna
requested review from
sfc-gh-sfan,
sfc-gh-aling,
sfc-gh-aalam and
sfc-gh-yixie
January 9, 2024 17:26
sfc-gh-aalam
reviewed
Jan 9, 2024
sfc-gh-jrose
reviewed
Jan 9, 2024
sfc-gh-nkrishna
added
the
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
label
Jan 9, 2024
sfc-gh-yixie
reviewed
Jan 9, 2024
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-nkrishna
force-pushed
the
interval
branch
from
January 9, 2024 20:07
df39a9d
to
4c9d17f
Compare
sfc-gh-yixie
reviewed
Jan 9, 2024
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-aalam
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Will wait for adam's comment
sfc-gh-aling
approved these changes
Jan 10, 2024
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-yixie
approved these changes
Jan 10, 2024
Signed-off-by: Naren Krishna <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds support for Interval expressions, which the Snowpark pandas team needs to support binary operations with pandas DateOffsets (using Interval keyword).