Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interval expression to Snowpark API #1191

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Add Interval expression to Snowpark API #1191

merged 11 commits into from
Jan 11, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Jan 4, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This PR adds support for Interval expressions, which the Snowpark pandas team needs to support binary operations with pandas DateOffsets (using Interval keyword).

Copy link

github-actions bot commented Jan 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-nkrishna
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-nkrishna
Copy link
Contributor Author

recheck

@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md and removed NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Jan 4, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna marked this pull request as ready for review January 9, 2024 17:26
@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner January 9, 2024 17:26
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-nkrishna sfc-gh-nkrishna added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 9, 2024
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Will wait for adam's comment

Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-yixie sfc-gh-yixie merged commit d924d78 into main Jan 11, 2024
57 checks passed
@sfc-gh-yixie sfc-gh-yixie deleted the interval branch January 11, 2024 00:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants