Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1000455: Incorrect return type hint in DataFrameNaFunctions class #1192

Closed
TedCha opened this issue Jan 4, 2024 · 0 comments · Fixed by #1195
Closed

SNOW-1000455: Incorrect return type hint in DataFrameNaFunctions class #1192

TedCha opened this issue Jan 4, 2024 · 0 comments · Fixed by #1195
Labels
bug Something isn't working needs triage Initial RCA is required

Comments

@TedCha
Copy link
Contributor

TedCha commented Jan 4, 2024

  1. What version of Python are you using?

Python 3.8.10 (tags/v3.8.10:3d8993a, May 3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]

  1. What operating system and processor architecture are you using?

Windows-10-10.0.19045-SP0

  1. What are the component versions in the environment (pip freeze)?
asn1crypto==1.5.1
certifi==2023.11.17      
cffi==1.16.0
charset-normalizer==3.3.2
cloudpickle==2.2.1       
colorama==0.4.6
cryptography==41.0.7     
exceptiongroup==1.2.0    
filelock==3.13.1
idna==3.6
iniconfig==2.0.0
numpy==1.24.4
packaging==23.2
pandas==2.0.3
platformdirs==3.11.0
pluggy==1.3.0
pyarrow==14.0.2
pycparser==2.21
PyJWT==2.8.0
pyOpenSSL==23.3.0
pytest==7.4.4
python-dateutil==2.8.2
pytz==2023.3.post1
PyYAML==6.0.1
requests==2.31.0
six==1.16.0
snowflake-connector-python==3.6.0
snowflake-snowpark-python==1.11.1
sortedcontainers==2.4.0
tomli==2.0.1
tomlkit==0.12.3
typing_extensions==4.9.0
tzdata==2023.4
urllib3==1.26.18
  1. What did you do?

When using any of the DataFrameNaFunctions methods, the return type will be Unknown.

import snowflake.snowpark as snowpark
from snowflake.snowpark.types import StructType, StructField, StringType

def main(session: snowpark.Session):

    schema = StructType([StructField("A", StringType())])
    df = session.create_dataframe([], schema) # snowflake.snowpark.dataframe.DataFrame
    
    df = df.na.drop() # Unknown
  1. What did you expect to see?

The return type should be snowflake.snowpark.dataframe.DataFrame.

  1. Can you set logging to DEBUG and collect the logs?

Don't think logs are applicable as issue is with type hinting but can provide screenshots:

image

image

@TedCha TedCha added bug Something isn't working needs triage Initial RCA is required labels Jan 4, 2024
@github-actions github-actions bot changed the title Incorrect DataFrame return type hint in dataframe_na_functions.py SNOW-1000455: Incorrect DataFrame return type hint in dataframe_na_functions.py Jan 4, 2024
@TedCha TedCha changed the title SNOW-1000455: Incorrect DataFrame return type hint in dataframe_na_functions.py SNOW-1000455: Incorrect return type hint in DataFrameNaFunctions class Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Initial RCA is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant