-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1018248: Add support for asof join in snowpark #1254
SNOW-1018248: Add support for asof join in snowpark #1254
Conversation
https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/901/ Add tests have passed on SP side related to ASOF join |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
nit: I'd prefer if the tests were parameterized so that each test case is considered a separate test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I am not able to understand the code line by line, but just looked at the test cases and it looks good to me. One question though: There are some restrictions on the as of join sql, like match_condition can only have >=, >, <= and < operators, on clause of asof join can have conjuction of equi conditions or so. Will these be relying on the SQL engine? Can we have tests for these cases?
We will rely on sql engine to throw errors for these cases.
Sure. I'll add tests for them |
646ce46
to
aacfc37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you. (Not an expert for the code. only reviewed in high level)
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-1018248
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add ASOF join support in snowpark python.