SNOW-1304211: Pylance throws errors when using copy_options with copy_into_location method #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Yoshi-Egawa
changed the title
sfc-gh-stan
approved these changes
Apr 5, 2024
| @@ -240,7 +240,7 @@ def copy_into_location( | |||
| header: bool = False, | |||
| statement_params: Optional[Dict[str, str]] = None, | |||
| block: bool = True, | |||
There was a problem hiding this comment.
Suggested change
| block: bool = True, | |
| block: Literal[True], |
| @@ -256,7 +256,7 @@ def copy_into_location( | |||
| header: bool = False, | |||
| statement_params: Optional[Dict[str, str]] = None, | |||
| block: bool = False, | |||
There was a problem hiding this comment.
Suggested change
| block: bool = False, | |
| block: Literal[False], |
|
@sfc-gh-stan I have added a default value to the blocks keyword argument. This is because keyword arguments are optional, and not providing a value would result in an error. |
sfc-gh-stan
approved these changes
Apr 8, 2024
sfc-gh-jrose
approved these changes
Apr 8, 2024
sfc-gh-stan
added
the
NO-CHANGELOG-UPDATES
|
Tests kicked off by #1377, will merge after merge gates pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1304211: Pylance throws errors when using
copy_optionswithcopy_into_locationmethod #1363Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
src/snowflake/snowpark/dataframe_writer.py: Thecopy_into_locationmethod was updated in three instances. Thecopy_optionsparameter was changed fromOptional[str]toOptional[Dict[str, Any]]. This change allows for a wider range of types to be accepted as copy options, providing more flexibility when calling the method. [1] [2] [3]