Fixed import from context bug #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
requested review from
sfc-gh-sfan,
sfc-gh-yuwang and
sfc-gh-jrose
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-yixie
approved these changes
Apr 23, 2024
sfc-gh-bdufour
added
the
NO-CHANGELOG-UPDATES
sfc-gh-stan
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
There is no open Github issue for this PR as it is initiated internally within Snowflake.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
A bug was identified in PR #1397 whereby the first time the udf_utils module is loaded, the callback value is read and never updated. This is because of the semantics of
from ... importin Python (vsimport <module>). The bug was not detected by the existing tests because they incorrectly mocked the state. The tests have been updated now, and the behaviour was verified manually through an end-to-end example. I verified that the tests fail without the associated code change.