Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1297161: Add daily_modin_precommit.yml and update combine coverage for precommit.yml to include Modin tests #1421

Merged
merged 8 commits into from
Apr 25, 2024
Merged

SNOW-1297161: Add daily_modin_precommit.yml and update combine coverage for precommit.yml to include Modin tests #1421

merged 8 commits into from
Apr 25, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Apr 25, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1297161

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds daily_modin_precommit.yml and updates combine coverage for precommit.yml to include Modin tests.

@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 25, 2024
@sfc-gh-nkrishna
update env vars
04b0cb8 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna marked this pull request as ready for review April 25, 2024 15:50
@sfc-gh-nkrishna sfc-gh-nkrishna requested review from a team as code owners April 25, 2024 15:50
sfc-gh-azhan
sfc-gh-azhan reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the ownership for daily_modin_precommit.yaml file?

sfc-gh-azhan
sfc-gh-azhan requested changes Apr 25, 2024
View reviewed changes
.github/workflows/daily_precommit.yml Outdated Show resolved Hide resolved
.github/workflows/daily_modin_precommit.yml Outdated Show resolved Hide resolved
@sfc-gh-nkrishna
Copy link
Contributor Author

Can you also change the ownership for daily_modin_precommit.yaml file?

Do you mean change CODEOWNERS accordingly?

@sfc-gh-nkrishna sfc-gh-nkrishna changed the title SNOW-1297161: Add daily_modin_precommit.yml SNOW-1297161: Add daily_modin_precommit.yml and update combine coverage for precommit.yml to include Modin tests Apr 25, 2024
@sfc-gh-nkrishna
remove extraneous dependencies
9241d14 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna
fix linting
0ffcc7e 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna enabled auto-merge (squash) April 25, 2024 23:19
@sfc-gh-nkrishna sfc-gh-nkrishna merged commit 2ade2d4 into main Apr 25, 2024
24 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the nkrishna-SNOW-1297161-daily-precommit branch April 25, 2024 23:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-nkrishna @sfc-gh-azhan @sfc-gh-jdu @sfc-gh-jkew @sfc-gh-helmeleegy