Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1345421: Include pandas requirements in modin extra requirements. #1422

Merged
merged 4 commits into from
Apr 25, 2024
Merged

SNOW-1345421: Include pandas requirements in modin extra requirements. #1422

merged 4 commits into from
Apr 25, 2024

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1345421

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Include pandas requirements in modin extra requirements.

@sfc-gh-mvashishtha sfc-gh-mvashishtha added NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Apr 25, 2024
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review April 25, 2024 16:30
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested review from a team as code owners April 25, 2024 16:30
sfc-gh-jkew
sfc-gh-jkew reviewed Apr 25, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@sfc-gh-mvashishtha sfc-gh-mvashishtha mentioned this pull request Apr 25, 2024
Merged
5 tasks
sfc-gh-jdu
sfc-gh-jdu reviewed Apr 25, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
.github/workflows/precommit.yml Show resolved Hide resolved
sfc-gh-azhan
sfc-gh-azhan reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-mvashishtha can you do a rebase once #1425 is in?

sfc-gh-azhan
sfc-gh-azhan reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure those files are owned by both teams?

tests/integ/modin/test_modin_extra_without_pandas_extra.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
.github/workflows/precommit.yml Show resolved Hide resolved
@sfc-gh-mvashishtha
Copy link
Contributor Author

Can we make sure those files are owned by both teams?

@sfc-gh-nkrishna is doing that in #1425

@sfc-gh-mvashishtha
Remove tuple
a9004dd 
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha enabled auto-merge (squash) April 25, 2024 18:59
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit e1af086 into main Apr 25, 2024
24 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-1345421/fix-modin-extra branch April 25, 2024 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew left review comments

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-mvashishtha @sfc-gh-azhan @sfc-gh-jdu @sfc-gh-nkrishna @sfc-gh-jkew @sfc-gh-helmeleegy