Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pip install -e '.[modin-development]' installs all necessary dependencies #1425

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Apr 25, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This PR changes setup.py to ensure pip install -e '.[modin-development] installs all necessary dependencies so users don't have to do pip install -e '.[modin-development, development, pandas].

@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner April 25, 2024 17:26
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title Ensure pip install -e '.[modin-development]' install all necessary de… Ensure pip install -e '.[modin-development]' install all necessary dependencies Apr 25, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 25, 2024
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add setup.py's ownership to both teams.

@sfc-gh-lspiegelberg
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.
    Please write a short description of how your code change solves the related issue.

Can we add a description/ticket to track this?

@sfc-gh-joshi
Copy link
Contributor

Did we also want to add pytest-xdist to modin-development dependencies? I don't see it in this PR either https://github.com/snowflakedb/snowpark-python/pull/1422/files

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@sfc-gh-mvashishtha
Copy link
Contributor

Did we also want to add pytest-xdist to modin-development dependencies? I don't see it in this PR either

nit: we need to add pytest-xdist to both modin-development and development. Ideally we would add it in a separate PR.

Signed-off-by: Naren Krishna <[email protected]>
setup.py Outdated Show resolved Hide resolved
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sfc-gh-nkrishna sfc-gh-nkrishna enabled auto-merge (squash) April 25, 2024 20:16
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title Ensure pip install -e '.[modin-development]' install all necessary dependencies Ensure pip install -e '.[modin-development]' installs all necessary dependencies Apr 25, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna enabled auto-merge (squash) April 25, 2024 20:17
@sfc-gh-nkrishna sfc-gh-nkrishna merged commit 574e923 into main Apr 25, 2024
26 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the modin_development branch April 25, 2024 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants