-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure pip install -e '.[modin-development]'
installs all necessary dependencies
#1425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add setup.py's ownership to both teams.
Can we add a description/ticket to track this? |
Did we also want to add |
nit: we need to add pytest-xdist to both modin-development and |
…pendencies Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
2c0d30a
to
3425f4e
Compare
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
pip install -e '.[modin-development]'
installs all necessary dependencies
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR changes
setup.py
to ensurepip install -e '.[modin-development]
installs all necessary dependencies so users don't have to dopip install -e '.[modin-development, development, pandas]
.