Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1347796: Fix incorrect regex used in Series.str.contains #1436

Merged
merged 1 commit into from
Apr 26, 2024
Merged

SNOW-1347796: Fix incorrect regex used in Series.str.contains #1436

merged 1 commit into from
Apr 26, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Apr 26, 2024 •
edited by sfc-gh-mvashishtha
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1347796

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Fix incorrect regex used in Series.str.contains.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner April 26, 2024 08:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-helmeleegy sfc-gh-helmeleegy added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 26, 2024
@sfc-gh-helmeleegy
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-jkew
sfc-gh-jkew approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you ever find out why the doc test wasn't catching this?

@sfc-gh-helmeleegy
Copy link
Contributor Author

LGTM, did you ever find out why the doc test wasn't catching this?

Couldn't find a reason yet :( I'm worried that they may not be getting run for some reason! I ran the example from the doc test in python and it failed (before this change).

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit e8270b2 into main Apr 26, 2024
26 of 28 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1347796 branch April 26, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew approved these changes

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar was automatically assigned from snowflakedb/snowpandas

@sfc-gh-evandenberg sfc-gh-evandenberg Awaiting requested review from sfc-gh-evandenberg sfc-gh-evandenberg was automatically assigned from snowflakedb/snowpandas

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-helmeleegy @sfc-gh-vbudati @sfc-gh-jkew