Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1348457:Fix Reading files from Stage with Snowpark.session.read + INFER_SCHEMA option causes an error if the filename has a whitespace #1449

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

sfc-gh-yuwang
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1348457

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang
Copy link
Collaborator Author

when reading a stage file with space in its name, we need to use single quote to surround that file name. Infer schema will produce error because it always add a pair of single quotes to the stage file it want to infer. I use util.unwrap_single_quote to remove single quote when infer stage file

@sfc-gh-yuwang sfc-gh-yuwang requested review from sfc-gh-yijli and sfc-gh-yixie and removed request for sfc-gh-yijli April 29, 2024 21:08
@sfc-gh-yuwang sfc-gh-yuwang merged commit 2a236b6 into main Apr 30, 2024
24 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-1348457 branch April 30, 2024 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants