Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields that come from macros should come from macros always #27

Closed
rlh1994 opened this issue Feb 1, 2024 · 0 comments · Fixed by #28
Closed

Fields that come from macros should come from macros always #27

rlh1994 opened this issue Feb 1, 2024 · 0 comments · Fixed by #28
Assignees
Labels
category:models Related to the models in the package. priority:low Not on the roadmap. status:completed Completed - but might not be released yet. type:enhancement New features or improvements to existing features.

Comments

@rlh1994
Copy link
Contributor

rlh1994 commented Feb 1, 2024

Is your feature request related to a problem? Please describe.

Sometimes we refer to columns that have come from field group macros by macro, and sometimes by name. We should use the macro throughout to make it easier to make changes in the future, and in case a user overwrites the macro.

e.g.

{% if var('snowplow__enable_iab') %}
{{ iab_context_fields('ev') }}
{% endif %}

{% if var('snowplow__enable_iab') %}
, f.iab__category
, f.iab__primary_impact
, f.iab__reason
, f.iab__spider_or_robot
{% endif %}

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Are you interested in contributing towards this feature?

@rlh1994 rlh1994 added the type:enhancement New features or improvements to existing features. label Feb 1, 2024
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Feb 1, 2024
@rlh1994 rlh1994 added priority:low Not on the roadmap. category:models Related to the models in the package. and removed status:needs_triage Needs maintainer triage. labels Feb 1, 2024
@rlh1994 rlh1994 mentioned this issue Feb 8, 2024
20 tasks
@rlh1994 rlh1994 added the status:has_pr A PR exists for this issue. label Feb 8, 2024
@rlh1994 rlh1994 self-assigned this Feb 8, 2024
@rlh1994 rlh1994 added status:completed Completed - but might not be released yet. and removed status:has_pr A PR exists for this issue. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:models Related to the models in the package. priority:low Not on the roadmap. status:completed Completed - but might not be released yet. type:enhancement New features or improvements to existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant