Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If events are missing dvce_created_tstamp those events will be missing in base tables #174

Closed
stevensnicholas opened this issue Jul 8, 2024 · 5 comments
Assignees
Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@stevensnicholas
Copy link

There is the use of dvce_created_tstamp is in a predicate in the macro

dvce_sent_tstamp <= {{ snowplow_utils.timestamp_add('day', days_late_allowed, 'dvce_created_tstamp') }} -- don't process data that's too late
. If events are processed and contain dvce_created_tstamp they will be missing

@stevensnicholas stevensnicholas added the type:bug Bugs or weaknesses. The issue has to contain steps to reproduce. label Jul 8, 2024
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Jul 8, 2024
@miike
Copy link

miike commented Jul 9, 2024

@stevensnicholas Could you clarify what you mean by this?

If events are processed and contain dvce_created_tstamp they will be missing

This logic looks like as long as the dvce_created_tstamp is within the days_late_allowed threshold (when compared to dvce_sent_tstamp) it should be included in the model.

@stevensnicholas
Copy link
Author

Sorry, that was a poorly worded title - if either dvce_created_tstamp or dvce_sent_tstamp are null those rows will be missing from events this run. Because either side of that where clause will be comparing to null.

@miike
Copy link

miike commented Jul 11, 2024

Thanks - that makes sense let me raise with the team.

@miike
Copy link

miike commented Jul 18, 2024

Linking #176 as an update courtesy of the brilliant @agnessnowplow

@agnessnowplow
Copy link
Contributor

Closing as this should now be solved with the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Development

No branches or pull requests

3 participants