Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinesis: make writeToKinesis function tail recursive #644

Open
benjben opened this issue Jun 24, 2022 · 0 comments
Open

kinesis: make writeToKinesis function tail recursive #644

benjben opened this issue Jun 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@benjben
Copy link
Contributor

benjben commented Jun 24, 2022

At the moments there are 2 different levels of backoff retry :

  • One in case PutRecords request fails, orchestrated by cats-retry
  • One in case PutRecords succeeds but contains some failures, orchestrated "manually"

Thanks to trampolining we should be safe from stack overflows, but still it would be great to make the function tail recursive (requires to drop .retryingOnAllErrors). This would also guarantee that a record is retried only maxRetries even if the 2 types of retries are imbricated, which is not the case at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant