Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide whether pkg/transform should actually be defined as an interface like the other packages. #142

Open
colmsnowplow opened this issue Jun 13, 2022 · 0 comments
Open

Decide whether pkg/transform should actually be defined as an interface like the other packages. #142

colmsnowplow opened this issue Jun 13, 2022 · 0 comments
Labels
refactor Suggestion of a better way to factor the code

Comments

@colmsnowplow
Copy link
Collaborator

Small bit of discussion here: #126 (comment).

Initial implementation of pkg/transform/transform.go didn't define the package interface, as it provided an implementation of NewTransformation().

On reflection, I don't really see why it shouldn't be defined as an interface.

Same goes for pkg/transform/engine.go` - seems like this is essentially an interface for how custom scripting engines are provided.
@colmsnowplow colmsnowplow added the refactor Suggestion of a better way to factor the code label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Suggestion of a better way to factor the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colmsnowplow