Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate stack trace in SNOWError #730

Open
matus-tomlein opened this issue Nov 25, 2022 · 2 comments
Open

Truncate stack trace in SNOWError #730

matus-tomlein opened this issue Nov 25, 2022 · 2 comments

Comments

@matus-tomlein
Copy link
Contributor

Currently the stack trace is unbounded which can result in events failing validation. We should clip it to a max length.

@plu
Copy link

plu commented Nov 25, 2022

https://github.com/snowplow/snowplow-objc-tracker/blob/master/Snowplow/Internal/Events/SPTrackerError.m#L72

There's some code that tries to clip the max length, but not sure all code paths go through this.

@matus-tomlein
Copy link
Contributor Author

Hey @plu, you're right that the stack trace is truncated in the SPTrackerError event but it's not truncated in the SNOWError event.

The difference is that the SPTrackerError is tracked when tracker diagnostic autotracking is enabled. This includes log messages produced by the tracker.

On the other hand, the SNOWError is tracked when exception autotracking is enabled and it captures errors raised anywhere in the app code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants