Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow media/youtube enable functions to also accept an array of ids #1128

Open
greg-el opened this issue Oct 28, 2022 · 0 comments
Open

Allow media/youtube enable functions to also accept an array of ids #1128

greg-el opened this issue Oct 28, 2022 · 0 comments
Labels
type:enhancement New features or improvements to existing features.

Comments

@greg-el
Copy link
Contributor

greg-el commented Oct 28, 2022

Currently id is required to be a string, meaning the function (either enableYouTubeTracking or enableMediaTracking has to be called multiple times for as many videos. Allowing id to accept either a string or an array of strings would be a convenient way to track multiple videos.

From a cursory glance at the code it seems like it would be fairly straightforward to add in a non-breaking way.
@greg-el greg-el added the type:enhancement New features or improvements to existing features. label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greg-el