Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableButtonClickTracking disables tracking of buttons for all trackers #1397

Open
marcin-j opened this issue Dec 4, 2024 · 0 comments
Open
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@marcin-j
Copy link
Contributor

marcin-j commented Dec 4, 2024

Describe the bug
disableButtonClickTracking disables tracking of buttons for all trackers, and it doesn't allow to stop button click tracking only for the specified trackers.

To Reproduce
Steps to reproduce the behavior or code snippets that produce the issue:

  1. Create two seperate trackers.
  2. Call enableButtonClickTracking with specific trackers, e.g. trackerA and trackerB.
  3. Call disableButtonClickTracking.
  4. Observe that button click tracking is disabled for all trackers.

Expected behavior
disableButtonClickTracking should allow disabling button click tracking only for the specified trackers.

Desktop (please complete the following information):

  • OS: [e.g. macOS] n/a
  • Browser [e.g. Chrome, Safari] n/a
  • Version [e.g. 22] @snowplow/browser-plugin-button-click-tracking 3.24.3

Additional context
We still use tracker v3 as there are some breaking changes in v4 for us, and we need this fixed in v3 as well.

@marcin-j marcin-j added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Development

No branches or pull requests

1 participant