Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: Return to default simplelogger properties #1147

Open
istreeter opened this issue Dec 7, 2022 · 0 comments
Open

Loader: Return to default simplelogger properties #1147

istreeter opened this issue Dec 7, 2022 · 0 comments

Comments

@istreeter
Copy link
Contributor

RDB loader is unusual among Snowplow apps as we override the default simplelogger properties:

org.slf4j.simpleLogger.showLogName=false
org.slf4j.simpleLogger.showThreadName=false

I think this was done because historically we were grepping the logs to look for errors. But these days RDB loader has in-built monitoring and reporting. Was there any other reason we changed the defaults?

I think it would be helpful for debugging loader problems if we could see log names and thread names in the production logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant