Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSubSink use timeouts to set unhealthy sink #191

Open
istreeter opened this issue Dec 6, 2021 · 0 comments
Open

PubSubSink use timeouts to set unhealthy sink #191

istreeter opened this issue Dec 6, 2021 · 0 comments

Comments

@istreeter
Copy link
Contributor

The collector has a sink-health endpoint, which signals when the sink becomes unhealthy (even though webserver itself is completely healthy). Until now, the pubsub sink is marked as unhealthy only when the publisher has completely failed to sink some events. However, we are changing configuration so that by default the publisher retries indefinitely to sink all events, and therefore the sink would never get marked as unhealthy.

So we need an alternative algorithm to mark when the sink is unhealthy. This can be done by having a timeout, so if the event is not sunk within, say, 10 seconds then we mark the sink as unhealthy.

@istreeter istreeter added this to the 2.5.0 milestone Dec 6, 2021
@istreeter istreeter removed this from the 2.5.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant