Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test: Repository & UseCase #76

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Unit Test: Repository & UseCase #76

merged 10 commits into from
Nov 28, 2023

Conversation

thisisWooyeol
Copy link
Contributor

수정사항

  • Emoji, User, Post의 Repository, UseCase 클래스에 대한 unit test 코드를 작성하였습니다.
  • paging 반영 후 테스트 코드를 작성하기 위해 fetch~List 에 대한 테스트 코드는 TODO로 하였습니다

@thisisWooyeol
Copy link
Contributor Author

@yangchanhk98
Android CI에서 에러 내용을 확인해본 결과 썸네일 생성 코드가 추가되면서 ApplicationContext가 EmojiRepositoryImpl의 파라미터로 들어가게 되어 생긴 에러로 파악되었습니다. 머지 후 반영해 수정하겠습니다.

yangchanhk98
yangchanhk98 approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@yangchanhk98 yangchanhk98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 확인했습니다. 수정하시면 merge하겠습니다.

@thisisWooyeol thisisWooyeol merged commit 3bac2a5 into develop Nov 28, 2023
1 of 2 checks passed
@thisisWooyeol thisisWooyeol deleted the test/post-repo-unit branch November 28, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangchanhk98 yangchanhk98 yangchanhk98 approved these changes

@dawitfamanu dawitfamanu Awaiting requested review from dawitfamanu

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

Assignees

@peng-u-0807 peng-u-0807

@thisisWooyeol thisisWooyeol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisWooyeol @yangchanhk98 @peng-u-0807