Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🙏] Add optional secret to set dockercfg.json and integrationId #854

Open
JorritSalverda opened this issue Aug 17, 2021 · 3 comments
Open
Assignees

Comments

@JorritSalverda
Copy link

Describe the user need

In order to avoid having to manually create a snyk-monitor secret with dockercfg.json and integrationId item it would be useful to have an optional secret for this in the Helm chart. Right now we have to create a secondary internal Helm chart to create this secret in an automated fashion.

Describe expected behaviour

The values could look something like the following:

secret:
  enable: false
  dockercfg: {}
  integrationID: ""

It would be nice if the values for dockercfg and dockercfg are readable and get base64 encoded by the secret template.

@ivanstanev
Copy link
Contributor

Hey @JorritSalverda

Are you deploying the snyk-monitor in a non-default namespace? How does your current two-chart deployment process look like? I would imagine you would need to create the namespace in the first place automatically (otherwise you cannot deploy the chart) but I'm trying to understand why the secret cannot be created in a similar way, e.g. kubectl create namespace and kubectl create secret. Is this for an integration with a specific product e.g. ArgoCD?

@JorritSalverda
Copy link
Author

Hi @ivanstanev we're deploying snyk-monitor in namespace snyk-monitor.

We're using the helmfile tool to deploy multiple Helm charts into different namespaces for all of our clusters. The helmfile tool automatically creates the namespace for us, so we never use kubectl for rolling out our baseline tooling to 50+ GKE clusters.

There's now 2 charts we deploy to the snyk-monitor namespace, namely an internal one with the snyk-monitor secret and the snyk-charts/snyk-monitor chart that then uses that secret.

@Jimimaku
Copy link

Describe the user need

In order to avoid having to manually create a snyk-monitor secret with dockercfg.json and integrationId item it would be useful to have an optional secret for this in the Helm chart. Right now we have to create a secondary internal Helm chart to create this secret in an automated fashion.

Describe expected behaviour

The values could look something like the following:

secret:
  enable: false
  dockercfg: {}
  integrationID: ""

It would be nice if the values for dockercfg and dockercfg are readable and get base64 encoded by the secret template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants