Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posting Smart Contract Tests #31

Closed
5 tasks done
ryanycw opened this issue Aug 21, 2023 · 2 comments
Closed
5 tasks done

Posting Smart Contract Tests #31

ryanycw opened this issue Aug 21, 2023 · 2 comments
Assignees
@FoodChain1028
Labels
test test improvements

Comments

@ryanycw
Copy link
Member

ryanycw commented Aug 21, 2023 •
edited
Loading

Implement the Smart Contracts tests for posting. The following are the tests we discussed.

  • Happy Path: Post Success
    • Check Event Emit
  • Should fail with wrong proof
    • Check revert with the right message
  • Should fail with unsigned up user

Note: All tests should pass CICD
@ryanycw ryanycw added the test test improvements label Aug 21, 2023
@FoodChain1028
Copy link
Collaborator

After discussing with @iverJisty, we deem that unit tests in both parts should better separate into different files to avoid conflicts.

@FoodChain1028 FoodChain1028 mentioned this issue Aug 21, 2023
Merged
9 tasks
@ryanycw
Copy link
Member Author

ryanycw commented Aug 31, 2023

Closing this issue.

@ryanycw ryanycw closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FoodChain1028 FoodChain1028

Labels
test test improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanycw @FoodChain1028