Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh build find no config #52

Closed
NOOMA-42 opened this issue Aug 23, 2023 · 2 comments
Closed

fresh build find no config #52

NOOMA-42 opened this issue Aug 23, 2023 · 2 comments
Assignees
Labels
bug Something isn't working contracts test test improvements

Comments

@NOOMA-42
Copy link
Collaborator

Describe the bug
this happens in post-relay branch and branch rebased on it.
yarn deploy generates config.ts in root folder, but to build this branch current commit requires this config.ts which doesn't exist if you didn't run yarn deploy

To Reproduce
fresh clone test/post-relay branch and build

Expected behavior
For information, contracts package.json

"scripts": {
    "build": "yarn buildVerifier && hardhat compile && yarn abi",
    "buildVerifier": "ts-node ./scripts/genVerifier.ts ",
    "abi": "ts-node scripts/abi",
    "hardhat": "hardhat",
    "deploy": "hardhat run scripts/deploy.ts",

yarn deploy generates config.ts in root folder, but to build this branch current commit requires this config.ts which doesn't exist if you didn't run yarn deploy

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
relates to #25 #47

@github-actions github-actions bot added bug Something isn't working contracts test test improvements labels Aug 23, 2023
@NOOMA-42 NOOMA-42 assigned NOOMA-42 and iverJisty and unassigned NOOMA-42 Aug 24, 2023
@ryanycw
Copy link
Member

ryanycw commented Aug 25, 2023

Solving this in #25

@ryanycw
Copy link
Member

ryanycw commented Aug 25, 2023

This is solved #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contracts test test improvements
Projects
None yet
Development

No branches or pull requests

3 participants