Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request review comments #194

Open
jwilk opened this issue Aug 27, 2016 · 2 comments
Open

Pull request review comments #194

jwilk opened this issue Aug 27, 2016 · 2 comments

Comments

@jwilk
Copy link
Contributor

jwilk commented Aug 27, 2016

I'd love if git-hub supported creating Pull Request Review Comments.

@llucax llucax added this to the Future milestone Aug 27, 2016
@llucax
Copy link
Member

llucax commented Aug 27, 2016

There is limited support for simple comments, like for issues (although I'm not sure if the API changed and they still work because now they seem to have a commit ID associated).

Although, how do you envision an interface to do such comments, without an interactive UI is hard for me to visualize an interface to do comments on code.

@jwilk
Copy link
Contributor Author

jwilk commented Sep 6, 2016

I imagined that git-hub would open the diff in a text editor and let the user insert their comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants