rack: return generic error instead of leaking exception msg #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not use a middleware to do this, if that's your desire? |
|
Thanks for the quick response @ioquatix I can use a middleware to do this, but I thought that it might make more sense to change this to avoid leaking sensitive information. |
ioquatix
force-pushed
the
master
branch
4 times, most recently
from
77ce8ce
to
98a0ae6
Compare
|
This kind of relates to: #112 Would love to see this PR merged :) |
|
This is important, certain errors can contain sensitive or irrelevant info, and should not be shown to users. Using a middleware for solving this is a lot to ask for, since this is going against the grain of almost all app servers... |
|
@davidor can you rebase on master so I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98