Replies: 9 comments
-
There was a lot of activity on this issue but it's still open. Does the feature work (and it should be closed)? |
Beta Was this translation helpful? Give feedback.
-
@glasser I'm not 100% sure, but I'll discuss with @majek when I get a chance and either merge or close it. |
Beta Was this translation helpful? Give feedback.
-
Any update? |
Beta Was this translation helpful? Give feedback.
-
It looks like all of this was on a "dev" branch that never got merged. Is there any plan to merge this into master and release it? |
Beta Was this translation helpful? Give feedback.
-
The fix was way harder then anticipated and required major changes to the codebase, and eventually I gave up. Sorry. |
Beta Was this translation helpful? Give feedback.
-
If you use primus on top of sockjs it will send these heartbeat packages for you. From client -> server and the server will automatically disconnect if a heartbeat missing/timed out. See https://github.com/primus/primus#heartbeats-and-latency So if you really, this might be a viable option. |
Beta Was this translation helpful? Give feedback.
-
@majek that's too bad! We're testing out the "dev" branch with the heartbeats right now (it seems to be up to date w/ v0.3.4) and it appears to be working. @3rd-Eden Thanks for the pointer to Primus -- we'll definitely take a look at that! |
Beta Was this translation helpful? Give feedback.
-
Hi. This issue has been open for almost 5 years now. It was recently discussed in #297. Is there any plan to implement this feature? The client not being aware of the server disappearing from the network seems to be a major flaw. What is the "dev" branch mentioned above that has never been merged if one wants to take a look at it? |
Beta Was this translation helpful? Give feedback.
-
Are there any plans in implementing this issue? Is there any work around ? |
Beta Was this translation helpful? Give feedback.
-
The server may send an option telling the client how often it will send 'heartbeat' frames.
We should read this option and, indeed, expect heartbeats. We should kill the session on a heartbeat miss.
Beta Was this translation helpful? Give feedback.
All reactions