Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release creation fails when token is an empty string #541

Open
manferlo81 opened this issue Nov 8, 2024 · 0 comments
Open

Release creation fails when token is an empty string #541

manferlo81 opened this issue Nov 8, 2024 · 0 comments

Comments

@manferlo81
Copy link

manferlo81 commented Nov 8, 2024

I am using your action inside a composite action and I noticed it fails if the token if an empty string...

uses: softprops/action-gh-release@v2
with:
  token: ""

... in my case I am accepting an input named token and passing it through to your action, if the input is empty it will pass an empty string to your action causing it to fail. I solved to problem by taking into account the case the input is empty and handling myself. I believe this behavior is not the intended one, if it is, please feel free to close this issue.

I noticed you check for GITHUB_TOKEN before INPUT_TOKEN, is that what you intend?

github_token: env.GITHUB_TOKEN || env.INPUT_TOKEN || "",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant