Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network inspect tries to parse response as NetworkInfo, should be NetworkDetails #293

Open
cswinter opened this issue Apr 27, 2021 · 0 comments · May be fixed by #294
Open

network inspect tries to parse response as NetworkInfo, should be NetworkDetails #293

cswinter opened this issue Apr 27, 2021 · 0 comments · May be fixed by #294

Comments

@cswinter
Copy link
Contributor

Calling the network inspect function returns an error like missing field rx_dropped at line 1 column 1032. This is because the inspect function returns the NetworkInfo type when it should be returning NetworkDetails. PR incoming.
@cswinter cswinter linked a pull request Apr 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix network inspect type cswinter/shiplift
1 participant
@cswinter