Migrate next to main
#3303
Open
Migrate next to main
#3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This PR deprecates `Touchable` components in our repo ## Test plan Try importing any `Touchable` (or its `props`). After importing look at the console. --------- Co-authored-by: Jakub Piasecki <[email protected]>
## Description #3260 introduced a regression to the `Gesture Handlers`'s `TouchableNativeFeedback` component. The component used to be a direct reference to the `TouchableNativeFeedback`, which has a [couple of static methods](https://reactnative.dev/docs/touchablenativefeedback#methods). When it was replaced with a function component, the static methods got removed, leaving only the render function of the `TouchableNativeFeedback`. ## Test plan See how the type errors in the `example/src/release_tests/touchables/index.tsx` are resolved.
## Description This PR deprecates old Gesture Handler API. ## Test plan Try importing any handler from old API.
|
Do you think it'd make sense to rebase these changes onto main instead of squashing them? |
In our discussion with @j-piasecki we decided that it would be better to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates changed from next branch into
main.Test plan
Most of those commits are deprecations, to check
get/setrun example on web.