Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support packaging cairo-plugins in Scarb #1527

Closed
maciektr opened this issue Aug 20, 2024 · 2 comments · Fixed by #1605
Closed

Support packaging cairo-plugins in Scarb #1527

maciektr opened this issue Aug 20, 2024 · 2 comments · Fixed by #1605
Assignees
@DelevoXDG

Comments

@maciektr
Copy link
Contributor

  1. Handle packaging of builtin = true Cairo plugins - only manifest normalization
  2. Change package manifest normalization to include cairo-plugin section
  3. Allow packaging if target=lib or cairo-plugin (not only lib)
  4. Make sure verification runs for proc-macro plugins and builtin plugins
  5. (maybe design doc?) Do we need to package rust code with cargo package first? Do we need Cargo.toml manifest normalization?
@maciektr maciektr added this to Scarb Aug 20, 2024
@maciektr maciektr converted this from a draft issue Aug 20, 2024
@THenry14
Copy link
Member

Draft pull request opened here: #1586
It generally works for proc macros, but only with hardcoded paths. Things should definitely be refactored and improved.

@THenry14 THenry14 mentioned this issue Sep 11, 2024
Open
@maciektr
Copy link
Contributor Author

After this is done, integrate Foundry package uploads to CI
foundry-rs/starknet-foundry#2461
foundry-rs/starknet-foundry#2460

@DelevoXDG DelevoXDG mentioned this issue Sep 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 14, 2024
@DelevoXDG @maciektr
Support packaging cairo-plugins (#1605)
d01ccee 
## Changes
- Allow packaging cairo-plugins
- Run `cargo package` to normalize `Cargo.toml` and verify rust code for
proc macros
  - Skip `cargo package` and verification for builtin plugins
- Pass relevant configuration options from `scarb package` to `cargo
package`
- Update manifest normalization to include normalized `[cairo-plugin]`
section
- Fix `shared_lib_path` resolution to support packages mismatched scarb
/ cargo name and version

## Related issues
Closes #1527

---------

Signed-off-by: Maksim Zdobnikau <[email protected]>
Signed-off-by: maciektr <[email protected]>
Co-authored-by: maciektr <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scarb Oct 14, 2024
maciektr added a commit that referenced this issue Nov 18, 2024
@DelevoXDG @maciektr
Support packaging cairo-plugins (#1605)
728fed1 
## Changes
- Allow packaging cairo-plugins
- Run `cargo package` to normalize `Cargo.toml` and verify rust code for
proc macros
  - Skip `cargo package` and verification for builtin plugins
- Pass relevant configuration options from `scarb package` to `cargo
package`
- Update manifest normalization to include normalized `[cairo-plugin]`
section
- Fix `shared_lib_path` resolution to support packages mismatched scarb
/ cargo name and version

## Related issues
Closes #1527

---------

Signed-off-by: Maksim Zdobnikau <[email protected]>
Signed-off-by: maciektr <[email protected]>
Co-authored-by: maciektr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DelevoXDG DelevoXDG

Labels
None yet
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support packaging cairo-plugins software-mansion/scarb
3 participants
@THenry14 @maciektr @DelevoXDG