Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader-v3 programdata account size not counted towards to loaded-accounts-data-size-limit if executed through CPI #35611

Closed
tao-stones opened this issue Jul 24, 2024 · 1 comment

Comments

@tao-stones
Copy link
Contributor

Problem

@Lichtso repots:

we are not accounting for loader-v3 programs executed through CPI here:
https://github.com/anza-xyz/agave/blob/177f722410eada6b44cd3f65d992d9a846f21106/svm/src/account_loader.rs#L280
Since it was added (in [#29743](https://github.com/solana-labs/solana/pull/29743)) it was changed once to account for loader-v3 programdata accounts, but only in top-level instructions ([#30703](https://github.com/solana-labs/solana/pull/30703)).

Only in top-level instructions we use program.account_size from the program cache which correctly includes the loader-v3 programdata account length. The else branch however does use account.data().len() which is the proxy account length.

Add a test to demonstrate it.

Proposed Solution

Copy link
Contributor

This repository is no longer in use. Please re-open this issue in the agave repo: https://github.com/anza-xyz/agave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant