Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacedBy do not relate to modified message but initial message #44

Open
bourgeoa opened this issue Mar 10, 2023 · 4 comments
Open

replacedBy do not relate to modified message but initial message #44

bourgeoa opened this issue Mar 10, 2023 · 4 comments

Comments

@bourgeoa
Copy link
Member

As an exemple the initial message has been edited 3 times and is displayed 3 times :
this is due to subject being initial message and not previous modification
https://timbl.com/timbl/Public/Archive/solid/solidos/2023/03/09/chat.ttl

:HIYcpVGcR0CSkSMdkXzkntPj7LUU77jhurmjJ3-c-Lw
    dct:created "2023-03-09T18:26:18Z"^^xsd:dateTime;
    dct:isReplacedBy
        :cH0b-n7PH0-iYBMc8FddVQYsBvJ4KY8t7VPfFYdPeDk,
        :Edw9klVd9gvn0ErODpbQL1PEt9RWqKUelFZMRuZQ3yw,
        :pjlb4nvOUO_dNHqA8-gAe-AT9_DUUnIIdzGtE8WWh3g;
    sioc:content
        "Tim Berners-Lee:  [chat-threads] (https://github.com/SolidOS/solid-ui/tree/chat-threads\\) updated for lint, some tests. CI succeeded";
    sioc:id <matrix:///e/HIYcpVGcR0CSkSMdkXzkntPj7LUU77jhurmjJ3-c-Lw>;
    foaf:maker n5:this.

it should be :

:HIYcpVGcR0CSkSMdkXzkntPj7LUU77jhurmjJ3-c-Lw
    dct:isReplacedBy :cH0b-n7PH0-iYBMc8FddVQYsBvJ4KY8t7VPfFYdPeDk,
:cH0b-n7PH0-iYBMc8FddVQYsBvJ4KY8t7VPfFYdPeDk
        dct:isReplacedBy :Edw9klVd9gvn0ErODpbQL1PEt9RWqKUelFZMRuZQ3yw,
:Edw9klVd9gvn0ErODpbQL1PEt9RWqKUelFZMRuZQ3yw,
        dct:isReplacedBy :pjlb4nvOUO_dNHqA8-gAe-AT9_DUUnIIdzGtE8WWh3g.

@timbl
Copy link
Contributor

timbl commented Mar 10, 2023

Looks from the log that that is what comes from the Matrix server.

<< M [2023-03-09 18:26:18] m.room.message <bourgeoa-5bdf2c09d73408ce4fadd1b5:gitter.im> "bourgeoa (Alain Bourgeois)" ...3-c-Lw:-
<< M [2023-03-09 18:26:49] m.room.message <bourgeoa-5bdf2c09d73408ce4fadd1b5:gitter.im> "bourgeoa (Alain Bourgeois)" ...8WWh3g:-
   This REPLACES HIYcpVGcR0CSkSMdkXzkntPj7LUU77jhurmjJ3-c-Lw
<< M [2023-03-09 18:27:01] m.room.message <bourgeoa-5bdf2c09d73408ce4fadd1b5:gitter.im> "bourgeoa (Alain Bourgeois)" ...YdPeDk:-
   This REPLACES HIYcpVGcR0CSkSMdkXzkntPj7LUU77jhurmjJ3-c-Lw

@timbl
Copy link
Contributor

timbl commented Mar 10, 2023

https://spec.matrix.org/v1.6/client-server-api/#event-replacements

         The original event must not, itself, have a rel_type of m.replace
        (i.e. you cannot edit an edit — though you can send multiple edits for a single original event). 

@timbl
Copy link
Contributor

timbl commented Mar 10, 2023

I prefer our way of modeling it to matrix way, preserving the chain of versions.

@timbl
Copy link
Contributor

timbl commented Mar 12, 2023

See also Matrix change MSC2676 Message editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants