Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Update board column function #957

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mammabear123
Copy link
Contributor

Hi Alexander,

I'm still finishing off my evaluation of this change - but it certainly seems to work. However, I'd love your feedback on my approach and whether or not you think it 'fits' with the current code. I'd especially like to hear if you think I should have gone about this a different way.

The main complication is that the kanban column (see references) does not exist until after the work-item is created. For this reason I've chosen to only update the value in the 'last' revision. I also elected not to support setting the board column value for items with only a single revision as this would add unwarranted extra complexity - in most cases, these will be in the New column and will appear there by default anyway)

It is based on the following references:

@Alexander-Hjelm
Copy link
Collaborator

@mammabear123 Is this PR ready for merging now? It seems like both of my comments have been addressed. I had a quick look now and everything seems good!

Many thanks as always :)

@mammabear123
Copy link
Contributor Author

Oops I closed the wrong one :(

@mammabear123
Copy link
Contributor Author

@mammabear123 Is this PR ready for merging now?

It could be but I'm not sure.

All of the user reports I've looked into so far have been a failure to set up the ADO project with Board Columns in accordance with their configuration file. Importantly, this includes getting the Area Path correct, as ADO must/will validate against the Board that the card would appear on. What's more, if something is wrong, ADO just silently ignores it, and hence so does the migration tool. We have had no reports of this code causing regression of anything else though.

However, there are some reports that I haven't had a chance to investigate yet. It's up to you whether you want to wait for me to get around to that or not. I also haven't written any documentation for this feature yet, as you requested. So if you want to wait for that, then you'll have to wait for that :)

I would strongly recommend a clear note that this will only work if your ADO Board is set up correctly. And to double check the columns' name and status configuration, as well as area-path of your board if things go wrong. Many users have run into this issue perhaps even most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants