Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sidebar doesn't change tab to reference when changing to a reference page #800

Open
JoltCode opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working planned Features or content that are planned but not yet in progress. site improvement Something that improves the website functionality

Comments

@JoltCode
Copy link

JoltCode commented Jul 2, 2024

📝 Issue Description

The tabs on the left sidebar don't change according to whether it is a learn/reference section page.

📋 On which page(s) it occurs

All

🤔 Expected Behavior

When navigating to a reference page, the sidebar should change to reference, and vice versa for learn pages.

👀 Current Behavior

When you go to a reference page either via CMD+K or from a direct link, the sidebar is not on the correct tab.

🖥️ Browser

Arc Version 1.49.0 (51346) Chromium Engine Version 126.0.6478.127

📄 Additional Information

No response

@JoltCode JoltCode added bug Something isn't working pending review Awaiting review by team members. labels Jul 2, 2024
@JoltCode
Copy link
Author

JoltCode commented Jul 2, 2024

@atilafassina
Copy link
Member

Right, thanks for finding this.

It works well on soft navigation, but hard navigation doesn't.

Reproduction steps

  1. Navigate to https://docs.solidjs.com/solid-router/reference/data-apis/create-async
  2. Observe it loads the sidebar for the router correctly, but shows the learn tab instead of reference

@atilafassina atilafassina added planned Features or content that are planned but not yet in progress. and removed pending review Awaiting review by team members. labels Jul 2, 2024
@atilafassina atilafassina added the site improvement Something that improves the website functionality label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned Features or content that are planned but not yet in progress. site improvement Something that improves the website functionality
Projects
None yet
Development

No branches or pull requests

3 participants