Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content]: Catch-all parameter returns entire path not just the invalid part. #837

Open
klequis opened this issue Aug 5, 2024 · 0 comments
Labels
help wanted Looking for assistance on this issue improve documentation Enhance existing documentation.

Comments

@klequis
Copy link
Contributor

klequis commented Aug 5, 2024

📚 Subject area/topic

SolidStart > Routing

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/solid-start/building-your-application/routing#catch-all-routes

📋 Description of content that is out-of-date or incorrect

Doc says, "A catch-all route will have one parameter which is a forward-slash delimited string of all the URL segments after the last valid segment."

This is not correct. When a route is invalid the catch-all route's parameter contains the entire URL path, both valid and invalid segments.

It's crunch time for me, but I will follow-up with a PR unless the issue is closed.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@klequis klequis added improve documentation Enhance existing documentation. pending review Awaiting review by team members. labels Aug 5, 2024
@LadyBluenotes LadyBluenotes removed the pending review Awaiting review by team members. label Aug 27, 2024
@LadyBluenotes LadyBluenotes removed their assignment Aug 27, 2024
@LadyBluenotes LadyBluenotes added the help wanted Looking for assistance on this issue label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for assistance on this issue improve documentation Enhance existing documentation.
Projects
None yet
Development

No branches or pull requests

2 participants