Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content]: Store update path syntax - range of array indices is unclear #838

Closed
ak37165 opened this issue Aug 5, 2024 · 1 comment · Fixed by #893
Closed

[Content]: Store update path syntax - range of array indices is unclear #838

ak37165 opened this issue Aug 5, 2024 · 1 comment · Fixed by #893
Labels
help wanted Looking for assistance on this issue

Comments

@ak37165
Copy link

ak37165 commented Aug 5, 2024

📚 Subject area/topic

concepts/stores

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/concepts/stores#range-specification

📋 Description of content that is out-of-date or incorrect

The range specification first paragraph says you can specify a range of indices. So to cover all indices, I would think one would use
[0, array.length-1]

However, the example for array directly as the store uses to: store.length - should that be store.length-1 instead of store.length?

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@ak37165 ak37165 added improve documentation pending review Awaiting review by team members. labels Aug 5, 2024
@LadyBluenotes LadyBluenotes removed the pending review Awaiting review by team members. label Aug 27, 2024
@LadyBluenotes LadyBluenotes removed their assignment Aug 27, 2024
@LadyBluenotes LadyBluenotes added the help wanted Looking for assistance on this issue label Aug 27, 2024
@brenelz
Copy link
Collaborator

brenelz commented Sep 26, 2024

Yeah I think it should be store.length -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for assistance on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants