Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing]: Revive test suite for solid start #1667

Open
birkskyum opened this issue Oct 29, 2024 · 0 comments
Open

[Testing]: Revive test suite for solid start #1667

birkskyum opened this issue Oct 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Oct 29, 2024

It would be great for Solid Start to have a test suite again - it's currently entirely disabled, because it's using the legacy solid-start-node, and we need it to use vinxi.

The archived test folder is here:
https://github.com/solidjs/solid-start/tree/main/archived_test

There's an updated harness (the helpers folder) in the vinxi repo that can be reused for solid start

This is necessary to join the:

@birkskyum birkskyum added the enhancement New feature or request label Oct 29, 2024
@birkskyum birkskyum changed the title [Feature?]: Revive archived_test to current @solidjs/start [Testing]: Revive archived_test to current @solidjs/start Oct 29, 2024
@birkskyum birkskyum changed the title [Testing]: Revive archived_test to current @solidjs/start [Testing]: Revive test suite for solid start Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant