diff --git a/.circleci/config.yml b/.circleci/config.yml index 12bb10e..2fd7722 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,6 +1,9 @@ version: 2.1 orbs: + # Required for feature specs. + browser-tools: circleci/browser-tools@1.1 + # Always take the latest version of the orb, this allows us to # run specs against Solidus supported versions only without the need # to change this configuration every time a Solidus version is released @@ -8,20 +11,42 @@ orbs: solidusio_extensions: solidusio/extensions@volatile jobs: + run-specs-with-sqlite: + executor: + name: solidusio_extensions/sqlite + ruby_version: "3.0" + steps: + - browser-tools/install-chrome + - solidusio_extensions/run-tests run-specs-with-postgres: - executor: solidusio_extensions/postgres + executor: + name: solidusio_extensions/postgres + ruby_version: "3.0" steps: + - browser-tools/install-chrome - solidusio_extensions/run-tests run-specs-with-mysql: - executor: solidusio_extensions/mysql + executor: + name: solidusio_extensions/mysql + ruby_version: "3.0" steps: + - browser-tools/install-chrome - solidusio_extensions/run-tests + lint-code: + executor: + name: solidusio_extensions/sqlite-memory + ruby_version: "3.0" + steps: + - solidusio_extensions/lint-code workflows: "Run specs on supported Solidus versions": jobs: + - run-specs-with-sqlite - run-specs-with-postgres - run-specs-with-mysql + - lint-code + "Weekly run specs against master": triggers: - schedule: @@ -31,5 +56,6 @@ workflows: only: - master jobs: + - run-specs-with-sqlite - run-specs-with-postgres - run-specs-with-mysql diff --git a/.github/stale.yml b/.github/stale.yml index d9f6563..0d0b1c9 100644 --- a/.github/stale.yml +++ b/.github/stale.yml @@ -1,17 +1 @@ -# Number of days of inactivity before an issue becomes stale -daysUntilStale: 60 -# Number of days of inactivity before a stale issue is closed -daysUntilClose: 7 -# Issues with these labels will never be considered stale -exemptLabels: - - pinned - - security -# Label to use when marking an issue as stale -staleLabel: wontfix -# Comment to post when marking an issue as stale. Set to `false` to disable -markComment: > - This issue has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. -# Comment to post when closing a stale issue. Set to `false` to disable -closeComment: false \ No newline at end of file +_extends: .github diff --git a/.github_chagelog_generator b/.github_chagelog_generator new file mode 100644 index 0000000..eac0962 --- /dev/null +++ b/.github_chagelog_generator @@ -0,0 +1,2 @@ +issues=false +exclude-labels=infrastructure diff --git a/.gitignore b/.gitignore index bcd4aea..ae441fd 100644 --- a/.gitignore +++ b/.gitignore @@ -14,3 +14,8 @@ pkg *.swp spec/dummy spec/examples.txt +Gemfile-local +/sandbox +.rvmrc +.ruby-version +.ruby-gemset diff --git a/.rubocop.yml b/.rubocop.yml index b0893d3..ed101eb 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,14 +1,7 @@ +inherit_from: .rubocop_todo.yml + require: - solidus_dev_support/rubocop -inherit_gem: - solidus_dev_support: .rubocop.yml - AllCops: - Exclude: - - spec/dummy/**/* - - vendor/**/* - -Rails/SkipsModelValidations: - Exclude: - - db/migrate/**/* + NewCops: disable diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 0000000..cc65839 --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,38 @@ +Rails/HasManyOrHasOneDependent: + Enabled: false + +Rails/CreateTableWithTimestamps: + Enabled: false + +Layout/ArgumentAlignment: + Enabled: false + +Gemspec/RequiredRubyVersion: + Enabled: false + +RSpec/MultipleExpectations: + Enabled: false + +RSpec/LetSetup: + Enabled: false + +Layout/HashAlignment: + Enabled: false + +RSpec/NamedSubject: + Enabled: false + +RSpec/HookArgument: + Enabled: false + +Rails/ApplicationJob: + Enabled: false + +RSpec/DescribeClass: + Enabled: false + +RSpec/ContextWording: + Enabled: false + +Rails/SkipsModelValidations: + Enabled: false diff --git a/Gemfile b/Gemfile index a7fe8bc..00927e0 100644 --- a/Gemfile +++ b/Gemfile @@ -3,14 +3,17 @@ source 'https://rubygems.org' git_source(:github) { |repo| "https://github.com/#{repo}.git" } -branch = ENV.fetch('SOLIDUS_BRANCH', 'master') -solidus_git, solidus_frontend_git = if (branch == 'master') || (branch >= 'v3.2') - %w[solidusio/solidus solidusio/solidus_frontend] - else - %w[solidusio/solidus] * 2 - end -gem 'solidus', github: solidus_git, branch: branch -gem 'solidus_frontend', github: solidus_frontend_git, branch: branch +branch = ENV.fetch('SOLIDUS_BRANCH', 'main') +gem 'solidus', github: 'solidusio/solidus', branch: branch + +# The solidus_frontend gem has been pulled out since v3.2 +if branch >= 'v3.2' + gem 'solidus_frontend' +elsif branch == 'main' + gem 'solidus_frontend', github: 'solidusio/solidus_frontend', branch: branch +else + gem 'solidus_frontend', github: 'solidusio/solidus', branch: branch +end # Needed to help Bundler figure out how to resolve dependencies, # otherwise it takes forever to resolve them. @@ -20,7 +23,7 @@ gem 'rails', '>0.a' # Provides basic authentication functionality for testing parts of your engine gem 'solidus_auth_devise' -case ENV['DB'] +case ENV.fetch('DB', nil) when 'mysql' gem 'mysql2' when 'postgresql' @@ -29,4 +32,23 @@ else gem 'sqlite3' end +gem 'rails-controller-testing', group: :test + +group :development, :test do + gem 'factory_bot', '> 4.10.0' + gem 'pry-rails' +end + +# While we still support Ruby < 3 we need to workaround a limitation in +# the 'async' gem that relies on the latest ruby, since RubyGems doesn't +# resolve gems based on the required ruby version. +gem 'async', '< 3' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3') + gemspec + +# Use a local Gemfile to include development dependencies that might not be +# relevant for the project or for other contributors, e.g. pry-byebug. +# +# We use `send` instead of calling `eval_gemfile` to work around an issue with +# how Dependabot parses projects: https://github.com/dependabot/dependabot-core/issues/1658. +send(:eval_gemfile, 'Gemfile-local') if File.exist? 'Gemfile-local' diff --git a/Rakefile b/Rakefile index ecdfc67..4e3773f 100644 --- a/Rakefile +++ b/Rakefile @@ -1,6 +1,7 @@ # frozen_string_literal: true +require 'bundler/gem_tasks' require 'solidus_dev_support/rake_tasks' SolidusDevSupport::RakeTasks.install -task default: %w[extension:test_app extension:specs] +task default: 'extension:specs' diff --git a/bin/console b/bin/console old mode 100644 new mode 100755 diff --git a/bin/rails b/bin/rails old mode 100644 new mode 100755 index c535fd2..d9210f3 --- a/bin/rails +++ b/bin/rails @@ -1,15 +1,9 @@ -#!/usr/bin/env ruby - # frozen_string_literal: true -app_root = 'spec/dummy' +#!/usr/bin/env ruby -unless File.exist? "#{app_root}/bin/rails" - system "bin/rake", app_root or begin # rubocop:disable Style/AndOr - warn "Automatic creation of the dummy app failed" - exit 1 - end +if %w[g generate].include? ARGV.first + exec "#{__dir__}/rails-engine", *ARGV +else + exec "#{__dir__}/rails-sandbox", *ARGV end - -Dir.chdir app_root -exec 'bin/rails', *ARGV diff --git a/bin/rails-engine b/bin/rails-engine new file mode 100755 index 0000000..cd0aa1a --- /dev/null +++ b/bin/rails-engine @@ -0,0 +1,15 @@ +# frozen_string_literal: true + +#!/usr/bin/env ruby +# This command will automatically be run when you run "rails" with Rails gems +# installed from the root of your application. + +ENGINE_ROOT = File.expand_path('..', __dir__) +ENGINE_PATH = File.expand_path('../lib/solidus_slider/engine', __dir__) + +# Set up gems listed in the Gemfile. +ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__) +require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE']) + +require 'rails/all' +require 'rails/engine/commands' diff --git a/bin/rails-sandbox b/bin/rails-sandbox new file mode 100755 index 0000000..e73f02d --- /dev/null +++ b/bin/rails-sandbox @@ -0,0 +1,18 @@ +# frozen_string_literal: true + +#!/usr/bin/env ruby + +app_root = 'sandbox' + +unless File.exist? "#{app_root}/bin/rails" + warn 'Creating the sandbox app...' + Dir.chdir "#{__dir__}/.." do + system "#{__dir__}/sandbox" or begin + warn 'Automatic creation of the sandbox app failed' + exit 1 + end + end +end + +Dir.chdir app_root +exec 'bin/rails', *ARGV diff --git a/bin/rake b/bin/rake new file mode 100755 index 0000000..836ad3b --- /dev/null +++ b/bin/rake @@ -0,0 +1,7 @@ +#!/usr/bin/env ruby +# frozen_string_literal: true + +require 'rubygems' +require 'bundler/setup' + +load Gem.bin_path('rake', 'rake') diff --git a/bin/sandbox b/bin/sandbox new file mode 100755 index 0000000..7f7287b --- /dev/null +++ b/bin/sandbox @@ -0,0 +1,78 @@ +# frozen_string_literal: true + +#!/usr/bin/env bash + +set -e +test -z "${DEBUG+empty_string}" || set -x + +test "$DB" = "sqlite" && export DB="sqlite3" + +if [ -z "$SOLIDUS_BRANCH" ] +then + echo "~~> Use 'export SOLIDUS_BRANCH=[main|v3.2|...]' to control the Solidus branch" + SOLIDUS_BRANCH="main" +fi +echo "~~> Using branch $SOLIDUS_BRANCH of solidus" + +if [ -z "$SOLIDUS_FRONTEND" ] +then + echo "~~> Use 'export SOLIDUS_FRONTEND=[solidus_frontend|solidus_starter_frontend]' to control the Solidus frontend" + SOLIDUS_FRONTEND="solidus_frontend" +fi +echo "~~> Using branch $SOLIDUS_FRONTEND as the solidus frontend" + +extension_name="solidus_abandoned_carts" + +# Stay away from the bundler env of the containing extension. +function unbundled { + ruby -rbundler -e'b = proc {system *ARGV}; Bundler.respond_to?(:with_unbundled_env) ? Bundler.with_unbundled_env(&b) : Bundler.with_clean_env(&b)' -- $@ +} + +rm -rf ./sandbox +unbundled bundle exec rails new sandbox \ + --database="${DB:-sqlite3}" \ + --skip-bundle \ + --skip-git \ + --skip-keeps \ + --skip-rc \ + --skip-spring \ + --skip-test \ + --skip-javascript + +if [ ! -d "sandbox" ]; then + echo 'sandbox rails application failed' + exit 1 +fi + +cd ./sandbox +cat <> Gemfile +gem 'solidus', github: 'solidusio/solidus', branch: '$SOLIDUS_BRANCH' +gem 'rails-i18n' +gem 'solidus_i18n' +gem '$extension_name', path: '..' +group :test, :development do + platforms :mri do + gem 'pry-byebug' + end +end +RUBY + +unbundled bundle install --gemfile Gemfile + +unbundled bundle exec rake db:drop db:create + +unbundled bundle exec rails generate solidus:install \ + --auto-accept \ + --user_class=Spree::User \ + --enforce_available_locales=true \ + --with-authentication=true \ + --payment-method=none \ + --frontend=${SOLIDUS_FRONTEND} \ + $@ + +unbundled bundle exec rails generate solidus:auth:install --auto-run-migrations +unbundled bundle exec rails generate ${extension_name}:install --auto-run-migrations + +echo +echo "๐Ÿš€ Sandbox app successfully created for $extension_name!" +echo "๐Ÿงช This app is intended for test purposes." diff --git a/bin/setup b/bin/setup old mode 100644 new mode 100755 index c3563af..67d9193 --- a/bin/setup +++ b/bin/setup @@ -5,4 +5,4 @@ set -vx gem install bundler --conservative bundle update -bundle exec rake extension:test_app +bin/rake clobber diff --git a/lib/generators/solidus_abandoned_carts/install/install_generator.rb b/lib/generators/solidus_abandoned_carts/install/install_generator.rb index 8c52812..defb9dc 100644 --- a/lib/generators/solidus_abandoned_carts/install/install_generator.rb +++ b/lib/generators/solidus_abandoned_carts/install/install_generator.rb @@ -8,15 +8,15 @@ class InstallGenerator < Rails::Generators::Base class_option :auto_run_migrations, type: :boolean, default: false def add_migrations - run 'bundle exec rake railties:install:migrations FROM=solidus_abandoned_carts' + run 'bin/rails railties:install:migrations FROM=solidus_abandoned_carts' end def run_migrations - run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) + run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Layout/LineLength if run_migrations - run 'bundle exec rake db:migrate' + run 'bin/rails db:migrate' else - puts 'Skipping rake db:migrate, don\'t forget to run it!' # rubocop:disable Rails/Output + puts 'Skipping bin/rails db:migrate, don\'t forget to run it!' # rubocop:disable Rails/Output end end diff --git a/lib/solidus_abandoned_carts.rb b/lib/solidus_abandoned_carts.rb index cf9b1e0..d05a98c 100644 --- a/lib/solidus_abandoned_carts.rb +++ b/lib/solidus_abandoned_carts.rb @@ -1,8 +1,5 @@ # frozen_string_literal: true -require 'solidus_core' -require 'solidus_support' - require 'solidus_abandoned_carts/engine' require 'solidus_abandoned_carts/configuration' require 'solidus_abandoned_carts/version' diff --git a/lib/solidus_abandoned_carts/engine.rb b/lib/solidus_abandoned_carts/engine.rb index 9b60ee7..c11186f 100644 --- a/lib/solidus_abandoned_carts/engine.rb +++ b/lib/solidus_abandoned_carts/engine.rb @@ -1,12 +1,13 @@ # frozen_string_literal: true -require 'spree/core' +require 'solidus_core' +require 'solidus_support' module SolidusAbandonedCarts class Engine < Rails::Engine include SolidusSupport::EngineExtensions - isolate_namespace Spree + isolate_namespace ::Spree engine_name 'solidus_abandoned_carts' diff --git a/lib/solidus_abandoned_carts/factories.rb b/lib/solidus_abandoned_carts/testing_support/factories.rb similarity index 100% rename from lib/solidus_abandoned_carts/factories.rb rename to lib/solidus_abandoned_carts/testing_support/factories.rb diff --git a/lib/tasks/solidus_abandoned_carts/send_notification.rake b/lib/tasks/solidus_abandoned_carts/send_notification.rake index 332ac31..e1dea67 100644 --- a/lib/tasks/solidus_abandoned_carts/send_notification.rake +++ b/lib/tasks/solidus_abandoned_carts/send_notification.rake @@ -2,7 +2,7 @@ namespace :solidus_abandoned_carts do task send_notification: :environment do - puts "Sending abandoned carts notifications..." + puts 'Sending abandoned carts notifications...' abandonded_carts = Spree::Order.abandon_not_notified if abandonded_carts @@ -10,11 +10,11 @@ namespace :solidus_abandoned_carts do next unless order.last_for_user? Spree::NotifyAbandonedCartJob.perform_now(order) - end if abandonded_carts + end - puts "notifications sent: #{abandonded_carts.count}" + puts "Notifications sent: #{abandonded_carts.count}" end - puts "Done!" + puts 'Done!' end end diff --git a/solidus_abandoned_carts.gemspec b/solidus_abandoned_carts.gemspec index 30eb610..b4e63ff 100644 --- a/solidus_abandoned_carts.gemspec +++ b/solidus_abandoned_carts.gemspec @@ -15,22 +15,25 @@ Gem::Specification.new do |s| s.homepage = 'https://github.com/solidusio-contrib/solidus_abandoned_carts' if s.respond_to?(:metadata) - s.metadata["homepage_uri"] = s.homepage if s.homepage - s.metadata["source_code_uri"] = s.homepage if s.homepage + s.metadata['homepage_uri'] = s.homepage if s.homepage + s.metadata['source_code_uri'] = s.homepage if s.homepage end - s.required_ruby_version = ['>= 2.4', '< 4.0'] + s.required_ruby_version = '>= 2.5' - s.files = Dir.chdir(File.expand_path(__dir__)) do - `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } - end - s.test_files = Dir['spec/**/*'] - s.bindir = "exe" - s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) } - s.require_paths = ["lib"] + # Specify which files should be added to the gem when it is released. + # The `git ls-files -z` loads the files in the RubyGem that have been added into git. + files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") } + + s.files = files.grep_v(%r{^(test|spec|features)/}) + s.test_files = files.grep(%r{^(test|spec|features)/}) + s.bindir = 'exe' + s.executables = files.grep(%r{^exe/}) { |f| File.basename(f) } + s.require_paths = ['lib'] - s.add_dependency 'solidus_core', ['>= 2.0.0', '< 4'] - s.add_dependency 'solidus_support', '~> 0.5' + s.add_dependency 'solidus_core', ['>= 2.0.0', '< 5'] + s.add_dependency 'solidus_support', '~> 0.8' - s.add_development_dependency 'solidus_dev_support' + s.add_development_dependency 'rails-controller-testing' + s.add_development_dependency 'solidus_dev_support', '~> 2.7' end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 9287753..b6e1b8d 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,19 +3,33 @@ # Configure Rails Environment ENV['RAILS_ENV'] = 'test' +require 'rails-controller-testing' +Rails::Controller::Testing.install + # Run Coverage report require 'solidus_dev_support/rspec/coverage' -require File.expand_path('dummy/config/environment.rb', __dir__) +# Create the dummy app if it's still missing. +dummy_env = "#{__dir__}/dummy/config/environment.rb" +system 'bin/rake extension:test_app' unless File.exist? dummy_env +require dummy_env # Requires factories and other useful helpers defined in spree_core. require 'solidus_dev_support/rspec/feature_helper' -require 'rspec/rails' +# Requires supporting ruby files with custom matchers and macros, etc, +# in spec/support/ and its subdirectories. +Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f } -Dir[File.join(File.dirname(__FILE__), '/support/**/*.rb')].each { |file| require file } +# Requires factories defined in Solidus core and this extension. +# See: lib/solidus_slider/testing_support/factories.rb +SolidusDevSupport::TestingSupport::Factories.load_for(SolidusAbandonedCarts::Engine) RSpec.configure do |config| config.infer_spec_type_from_file_location! config.use_transactional_fixtures = false + + if Spree.solidus_gem_version < Gem::Version.new('2.11') + config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system + end end diff --git a/spec/support/rake.rb b/spec/support/rake.rb index 3a468cc..f59ae5a 100644 --- a/spec/support/rake.rb +++ b/spec/support/rake.rb @@ -3,7 +3,7 @@ # # Rake task spec setup. # -RSpec.shared_context "rake" do |task_path:, task_name:| +RSpec.shared_context 'rake' do |task_path:, task_name:| require 'rake' let(:task) do