Fix too deep options propagation during solidus install #295
Labels
bug
Something isn't working
Comments
3 tasks
kennyadsl
added a commit
to nebulab/solidus
that referenced
this issue
Apr 14, 2023
By removing the override of the `generate` method in this generator, we stop propagating those custom arguments to all the inner generators called by the installer. For example, at the moment, the installer is running rails generate rspec:install --auto-accept --auto-run-migrations see [1], which doesn't make sense and might also have unexpected behaviors if we (or any dependency) run a generator during their installation, which accepts those arguments. Instead of always propaging these option, we are explicitely declaring them when needed. [1]: solidusio/solidus_starter_frontend#295 Co-authored-by: safafa <[email protected]>
kennyadsl
added a commit
to nebulab/solidus
that referenced
this issue
Apr 14, 2023
By removing the override of the `generate` method in this generator, we stop propagating those custom arguments to all the inner generators called by the installer. For example, at the moment, the installer is running rails generate rspec:install --auto-accept --auto-run-migrations see [1], which doesn't make sense and might also have unexpected behaviors if we (or any dependency) run a generator during their installation, which accepts those arguments. Instead of always propaging these option, we are explicitely declaring them when needed. [1]: solidusio/solidus_starter_frontend#295 Co-authored-by: safafa <[email protected]>
kennyadsl
added a commit
to nebulab/solidus
that referenced
this issue
Apr 14, 2023
By removing the override of the `generate` method in this generator, we stop propagating those custom arguments to all the inner generators called by the installer. For example, at the moment, the installer is running rails generate rspec:install --auto-accept --auto-run-migrations see [1], which doesn't make sense and might also have unexpected behaviors if we (or any dependency) run a generator during their installation, which accepts those arguments. Instead of always propaging these option, we are explicitely declaring them when needed. [1]: solidusio/solidus_starter_frontend#295 Co-authored-by: safafa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
bin/sandboxwe can see how solidus options are propagated to other gem installation as well. In the sandbox generation logs:--auto-accept --auto-run-migrationsshould not be present.The text was updated successfully, but these errors were encountered: