Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running rails g solidus:install multiple times duplicates the gemfile block #363

Open
spaghetticode opened this issue Jan 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@spaghetticode
Copy link
Member

Solidus Version:
master

To Reproduce
Create a new solidus store, then run rails g solidus:install twice and pick the starter frontend from the options.

The second time, the Gemfile will include a list of duplicate gems, coming from https://github.com/solidusio/solidus_starter_frontend/blob/main/template.rb#L67-L98.

It's arguable that the install process should be idempotent (you should install only once), but if for some reason the first run breaks, then running it twice sounds legit to me, so we may want to avoid this duplication, which of course is not welcome by bundler complaining with Your Gemfile lists the gem responders (>= 0) more than once. You should probably keep only one of them. and such.

Current behavior
store frontend gems are added twice to the Gemfile

Expected behavior
store frontend gems are added only once to the Gemfile

@spaghetticode spaghetticode added the bug Something isn't working label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant