Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PDP subscription form #243

Open
vassalloandrea opened this issue Oct 28, 2021 · 1 comment
Open

Fix the PDP subscription form #243

vassalloandrea opened this issue Oct 28, 2021 · 1 comment
Labels

Comments

@vassalloandrea
Copy link

The PDP subscription form is not working correctly:

  1. it appears also if the product is not subscribable
  2. the default PDP quantity input is used to set the subscribable_id (the variant id)
  3. the interval units fields are not filled with a default value
  4. the subscription quantity is handled by a redundant field

Screen Shot 2021-10-27 at 17 55 02 PM

How to fix:

  1. show the subscription form only if the product or one of the product variant is subscribable
  2. use the default PDP quantity input to set the subscription quantity
  3. fill the interval units fields with a default value
  4. remove the redundant field
@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant