//test:test_sys_marker is failing

[AndrewGuenther]

I noticed while working on #9 that //test:test_sys_marker is failing on a clean checkout. Don't know if it's something about my environment or a legitimate regression. I can try to bisect and find when it may have started.

As an aside, that might be a good reason to set up Github actions to run tests on push/PRs

[AndrewGuenther]

After a bisect, I can confirm that this test was never passing.

The test was added in 05cc463, but didn't actually start running until 65dc84b at which point it started to fail. Going back and checking out 05cc463 again and ensuring the test actually runs, I can see that it was failing there as well.

Again, this could still be something about my environment, but digging through the code, I don't think that's the case.

[NathanHowell]

definitely should setup Github Actions for this one... but it does pass locally on a couple of my machines:

$ bazel clean
INFO: Starting clean.
$ bazel test //test:test_sys_marker
INFO: Analyzed target //test:test_sys_marker (34 packages loaded, 1155 targets configured).
INFO: Found 1 test target...
Target //test:test_sys_marker up-to-date:
  bazel-bin/test/test_sys_marker
INFO: Elapsed time: 6.712s, Critical Path: 3.86s
INFO: 13 processes: 9 internal, 4 darwin-sandbox.
INFO: Build completed successfully, 13 total actions
//test:test_sys_marker                                                   PASSED in 0.4s

[NathanHowell]

@AndrewGuenther is this still an issue? I wasn't able to repro it and CI builds pass as well

[njlr]

@AndrewGuenther is this still an issue? I wasn't able to repro it and CI builds pass as well

The CI has this test disabled:

https://github.com/soniaai/rules_poetry/blob/master/test/BUILD#L36

[NathanHowell]

@njlr ah yes, I see. it looks like recent poetry versions stopped adding markers to the lock file, so they would need to be parsed out of the pyproject.toml. hum.