"sudo config interface ip remove ..." fails when BGP feature is disabled

[FireStormOOO]

Description

When the BGP feature is disabled or not running, as in a typical layer 2 switch config, IP addresses cannot be removed from interfaces.

Steps to reproduce the issue:

1. sudo config interface ip add SomePortChannel SomeValidIP/Net
2. sudo config feature state bgp disabled
   a. show feature status reports bgp disabled; may take several seconds
3. sudo config interface ip remove SomePortChannel SomeValidIP/Net
   a. Error response from daemon: No such container: bgp
   b. Alternately, if bgp was running but stopped:
   c. Error response from daemon: Container (long name) is not running
   b. In either case, IP is not removed

Showing the issue is in fact BGP as the command reports:

1. sudo config feature state bgp enabled
   a. show feature status reports bgp enabled; may take several seconds
2. sudo config interface ip remove SomePortChannel SomeValidIP/Net
   a. Command returns without error
   b. IP is removed

No change if this is done with a plain Ethernet port instead of portchannel

Describe the results you received:

Switch is unable to remove IPs from interfaces without the BGP container running, preventing use as a layer 2 switch without running extra services.

Describe the results you expected:

Interfaces should be configurable without dependency on dynamic routing protocols. Command should not attempt to make changes to BGP if the feature is not enabled.

Output of show version:

SONiC Software Version: SONiC.202411.0-2ad469032
SONiC OS Version: 12
Distribution: Debian 12.8
Kernel: 6.1.0-22-2-amd64
Build commit: 2ad469032
Build date: Mon Dec 23 09:57:47 UTC 2024
Built by: <local build>

Platform: x86_64-cel_seastone-r0
HwSKU: Seastone-DX010
ASIC: broadcom
ASIC Count: 1
Serial Number: DX010F2B077301LK000010
Model Number: R0872-F0009-01
Hardware Revision: N/A
Uptime: 04:19:46 up 23:03,  1 user,  load average: 1.81, 1.94, 1.59
Date: Thu 26 Dec 2024 04:19:46

Docker images:
REPOSITORY                    TAG                  IMAGE ID       SIZE
docker-orchagent              202411.0-2ad469032   bf08f3f44977   531MB
docker-orchagent              latest               bf08f3f44977   531MB
docker-nat                    202411.0-2ad469032   f32d06e4f72f   444MB
docker-nat                    latest               f32d06e4f72f   444MB
docker-fpm-frr                202411.0-2ad469032   317a93172cef   481MB
docker-fpm-frr                latest               317a93172cef   481MB
docker-dhcp-server            latest               cc5f7eeac4c3   513MB
docker-dhcp-relay             latest               9cd932f65e0d   495MB
docker-iccpd                  202411.0-2ad469032   3182c964a853   445MB
docker-iccpd                  latest               3182c964a853   445MB
docker-macsec                 latest               0e7082de0328   444MB
docker-syncd-brcm             202411.0-2ad469032   d10b5325b3a1   852MB
docker-syncd-brcm             latest               d10b5325b3a1   852MB
docker-sonic-mgmt-framework   202411.0-2ad469032   0f1e549aeea2   579MB
docker-sonic-mgmt-framework   latest               0f1e549aeea2   579MB
docker-snmp                   202411.0-2ad469032   b34560a5b6d6   521MB
docker-snmp                   latest               b34560a5b6d6   521MB
docker-platform-monitor       202411.0-2ad469032   5015f25345a4   640MB
docker-platform-monitor       latest               5015f25345a4   640MB
docker-teamd                  202411.0-2ad469032   7b9bf76e311b   441MB
docker-teamd                  latest               7b9bf76e311b   441MB
docker-sflow                  202411.0-2ad469032   d301dce4ff78   442MB
docker-sflow                  latest               d301dce4ff78   442MB
docker-router-advertiser      202411.0-2ad469032   5b1e55b08416   410MB
docker-router-advertiser      latest               5b1e55b08416   410MB
docker-sonic-restapi          202411.0-2ad469032   7b00c96258a9   429MB
docker-sonic-restapi          latest               7b00c96258a9   429MB
docker-lldp                   202411.0-2ad469032   54c5804541e6   467MB
docker-lldp                   latest               54c5804541e6   467MB
docker-mux                    202411.0-2ad469032   4737d6fe7d79   473MB
docker-mux                    latest               4737d6fe7d79   473MB
docker-sonic-gnmi             202411.0-2ad469032   c372f7803903   500MB
docker-sonic-gnmi             latest               c372f7803903   500MB
docker-database               202411.0-2ad469032   d1d13cd2baa5   420MB
docker-database               latest               d1d13cd2baa5   420MB
docker-sonic-bmp              202411.0-2ad469032   caf480f64442   412MB
docker-sonic-bmp              latest               caf480f64442   412MB
docker-eventd                 202411.0-2ad469032   8ba2ce0ea394   410MB
docker-eventd                 latest               8ba2ce0ea394   410MB
docker-gbsyncd-broncos        202411.0-2ad469032   f92dd56eec40   480MB
docker-gbsyncd-broncos        latest               f92dd56eec40   480MB
docker-gbsyncd-credo          202411.0-2ad469032   1da8dda8752d   446MB
docker-gbsyncd-credo          latest               1da8dda8752d   446MB

Output of show techsupport:

Attached
sonic_dump_fss-dv-sw1_20241226_042130 - 1.tar.gz

Additional information you deem important (e.g. issue happens only occasionally):

Fresh local build of 202411 with:

make \
SONIC_VERSION_CACHE_METHOD=cache \
SONIC_DPKG_CACHE_METHOD=rwcache \
INCLUDE_ICCPD=y \
INCLUDE_RESTAPI=y \
INCLUDE_DHCP_SERVER=y \
ENABLE_BOOTCHART=y \
SONIC_BUILD_JOBS=4 \
target/sonic-broadcom.bin