Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Gap][PFCWD][T0&T1][Mellanox] PFC watchdog test on testbed with Non-Mellanox leaf-fanout #14411

Open
bingwang-ms opened this issue Sep 3, 2024 · 2 comments

Comments

@bingwang-ms
Copy link
Collaborator

bingwang-ms commented Sep 3, 2024

Test Gap Description

The PFC watchdog test set is flaky on Non-Mellanox leaf-fanout. Flaky test cases include

  • pfcwd/test_pfcwd_function.py
  • pfcwd/test_pfcwd_warm_reboot.py
  • pfcwd/test_pfcwd_timer_accuracy.py

It's because PR sonic-net/sonic-swss#3036 updated the PFC storm detection logic, which made PFC watchdog can hardly be triggered by sending PFC pause frames with pfc_gen.py on leaf-fanout.
The gap doesn't exist on testbed with Mellanox leaf fanout as there is a dedicated script which leverages ASIC to send PFC pause frames. https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/roles/test/files/mlnx/docker-tests-pfcgen-asic/pfc_gen.py

Test Plan

No response

Test environment

No response

Attach files (if any)

No response

@bingwang-ms
Copy link
Collaborator Author

@developfast @kperumalbfn FYI

@developfast
Copy link
Contributor

@bingwang-ms are you sure about this? I was able to trigger pfcwd with the script on all broadcom platforms when reproducing a prod issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants