Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On config interface shutdown, xcvrd to not reset CMIS state #258

Open
shyam77git opened this issue May 2, 2022 · 2 comments
Open

On config interface shutdown, xcvrd to not reset CMIS state #258

shyam77git opened this issue May 2, 2022 · 2 comments
Assignees

Comments

@shyam77git
Copy link

shyam77git commented May 2, 2022

While reviewing CMIS PR changeset - #254 , found following issue:
Discussed with @prgeor and following is to be done (corrected/enhanced):

Issue: Why the cmis state is reseted when config-interface shutdown is configured. It supposed to avoid app_code reprogramming during this state.
@jaganbal-a updated: As mentioned in the PR comment, We can have new state as CMIS_STATE_HOST_READY and this to be set under “elif state == self.CMIS_STATE_DP_DEINIT:” and self.CMIS_STATE_AP_CONF will be set only after the host_tx_ready is turned true. This will prevent moving state from DP_DEINIT to AP_CONF by default.

@shyam77git shyam77git changed the title On config interface shutdown, xcvrd to not reset CMIS state back to ready On config interface shutdown, xcvrd to not reset CMIS state May 2, 2022
@shyam77git
Copy link
Author

@jaganbal-a , @prgeor

@prgeor
Copy link
Collaborator

prgeor commented May 6, 2022

this is fixed in latest commit #254 ...please check.

@prgeor prgeor self-assigned this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants