Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CounterCheckOrch should be in sync with FlexCounterOrch #2957

Open
mint570 opened this issue Nov 11, 2023 · 0 comments
Open

CounterCheckOrch should be in sync with FlexCounterOrch #2957

mint570 opened this issue Nov 11, 2023 · 0 comments

Comments

@mint570
Copy link
Contributor

mint570 commented Nov 11, 2023

For port counters, flex counters need to be enabled to have the counters. If not, the CounterCheckOrch will keep printing warning logs about could not receive counters.

There are 4 functions that add a port into the CounterCheckOrch. They are generateQueueMapPerPort, createPortBufferQueueCounters, generatePriorityGroupMapPerPort, and createPortBufferPgCounters:

CounterCheckOrch::getInstance().addPort(port);

CounterCheckOrch::getInstance().addPort(port);

CounterCheckOrch::getInstance().addPort(port);

CounterCheckOrch::getInstance().addPort(port);

Amount those functions, only two of them add the port to FlexCounterOrch: createPortBufferQueueCounters and createPortBufferPgCounters.

We should make CounterCheckOrch and FlexCounterOrch to be in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant