Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfputil] fix firmware download progress not show 100% #3269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[sfputil] fix firmware download progress not show 100% #3269

wants to merge 1 commit into from

Conversation

rqx110
Copy link

@rqx110 rqx110 commented Apr 12, 2024

What I did

resolve #3266

correct the progress value disaplay when file is download complete

How I did it

How to verify it

run the command, and veriry the output

Previous command output (if the output of a command-line utility has changed)

root@sonic:/tmp# sfputil firmware download Ethernet0 /var/tmp/xxxx.bin
CDB: Starting firmware download
Platform doesn't implement optoe write max change. Skipping value increase.
Downloading ...  [###################################-]   99%  00:00:00
Platform doesn't implement optoe write max change. Skipping value restore!
CDB: firmware download complete

New command output (if the output of a command-line utility has changed)

root@sonic:/tmp# sfputil firmware download Ethernet0 /var/tmp/xxxx.bin
CDB: Starting firmware download
Platform doesn't implement optoe write max change. Skipping value increase.
Downloading ...  [####################################]  100%
Platform doesn't implement optoe write max change. Skipping value restore!
CDB: firmware download complete

@rqx110
Copy link
Author

rqx110 commented Sep 14, 2024 •
edited
Loading

Can some one review this? @prgeor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sfputil] the firmware download complete, the progress always show 99%
1 participant
@rqx110