Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search plugin should become external for 8.1 #2612

Open
dgw opened this issue Jul 15, 2024 · 1 comment · May be fixed by #2613
Open

search plugin should become external for 8.1 #2612

dgw opened this issue Jul 15, 2024 · 1 comment · May be fixed by #2613
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jul 15, 2024

The search plugin is kind of hacky, and often breaks for reasons outside of our control (e.g. IP reputation filtering or other anti-abuse measures). It would be great to replace it with an optional package that has more robust functionality, perhaps using duckduckgo-search (actively maintained as of writing; last update less than a week ago).

Once a suggested replacement is published, the built-in search plugin can be slated for removal.

@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jul 15, 2024
@dgw dgw added this to the 8.1.0 milestone Jul 15, 2024
@dgw dgw linked a pull request Aug 13, 2024 that will close this issue
4 tasks
@dgw
Copy link
Member Author

dgw commented Aug 13, 2024

sopel-search has been published and installed on our official Sopel instance; #2613 should handle everything we need related to this, once some type-checking shenanigans are handled by #2614. (Man, you leave some code alone for a month or two and BOOM, new errors without touching anything!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant