Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor chunk contains manifest file [since 1.1.2] #49

Open
mbrevda opened this issue Aug 2, 2017 · 2 comments
Open

vendor chunk contains manifest file [since 1.1.2] #49

mbrevda opened this issue Aug 2, 2017 · 2 comments

Comments

@mbrevda
Copy link

mbrevda commented Aug 2, 2017

When using chunk-manifest-webpack-plugin with CommonsChunkPlugin, it seems my manifest file is "leaking" into the common chunk's files. I'm including new ChunkManifestPlugin({filename: 'wpManifest.json'}) in my plugins, as well as

new webpack.optimize.CommonsChunkPlugin({
        name: 'vendor',
        minChunks: ({resource}) => /node_modules/.test(resource)
    })

Looking in stats.compilation.chunks, I see that the vendor chunk now has the manifest listed in it!

// from console.log of parts of stats.compilation.chunks
foo [ 'fdc9b7b128.js', 'fdc9b7b128.js.map' ]
bar [ '2f10fcf981.js', '2f10fcf981.js.map' ]
app [ 'app-36a1f801d3.js', 'app-36a1f801d3.js.map' ]
vendor [ 'wpManifest.json',
  'vendor-8d40f60f58.js',
  'vendor-8d40f60f58.js.map' ]

Surely that shouldn't be there?

@MatTheCat
Copy link

Probably duplicate of #47 and #48

@mbrevda
Copy link
Author

mbrevda commented Aug 6, 2017

Quite possible 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants